Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our dependencies are incompatible with node v18. To fix that, we need to upgrade a couple of packages.
Setting node to v17 lets
yarn install
complete successfully, butyarn serve
fails.this error happens because node v17 increased their security by disallowing some openssl protocols, I think. It is webpack 4 that causes these issues:
webpack/webpack#14532
vuejs/vue-cli#6770
By upgrading Vue plugins, they no longer depend on webpack v4, but v5, in which this is fixed.
The dependency on @achrinza/node-ipc@9.2.2 which only supports node up to v17 is also fixed by upgrading Vue plugins.
this allows us to use node v18 which is LTS now. v16 is in maintenance mode which ends in September 2023, so it's good to upgrade.
I also removed the dependency on node-sass which is deprecated in favor of sass:
https://stackoverflow.com/questions/71818513/node-sass-version-7-0-1-is-incompatible-with-4-0-0
vuejs/vue-cli#6477
I had to add a rule to eslint because in eslint-plugin-vue v7.0.0, they introduced a new rule for v-slot:
https://eslint.vuejs.org/rules/valid-v-slot.html#options
https://vuetifyjs.com/en/components/data-tables/#slots
https://stackoverflow.com/questions/61344980/v-slot-directive-doesnt-support-any-modifier