Fix compatibility with Docker 25+ #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for OCI-compatible Docker images. Fixes #498
|
also fixes #452 |
|
Is it backwards compatible ? |
|
@Kerwood - I've confirmed this works with both the new format and is backwards compatible |
|
For those currently stuck (and don't want to build it themselves), I did build and publish it under my namespace (and it's multi-arch!). Image here - |
wagoodman
approved these changes
Jan 31, 2024
|
When is it going to be released? |
|
I'm shooting for today |
zevisert
reviewed
Feb 15, 2024
|
|
||
| // 512 bytes ought to be enough (as that's the size of a TAR entry header), | ||
| // but play it safe with 1024 bytes. This should also include very small layers | ||
| // (unless they've also been gzipped, but Docker does not appear to do it) |
There was a problem hiding this comment.
I have a counter-example that's breaking this assumption, here's the layer from an image manifest that I've provided as a repro in #507
{
"schemaVersion": 2,
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"config" { ... },
"layers": [
{ ... },
{ ... },
{
"mediaType": "application/vnd.oci.image.layer.v1.tar+gzip", // <- This layer is gzipped
"digest": "sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1",
"size": 32 // <- this layer is also very small
}
]
}
oribe1115
added a commit
to tklab-group/docker-image-disassembler
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for OCI-compatible Docker images.
Fixes #498