Added false in save function to skip model validation

[Jaivignesh-afk]

Fixes #9703

added clean = False to skip model validation during unlocking a page as mentioned by @prgood in #9703

Please check the following:

• Do the tests still pass?¹
• Does the code comply with the style guide?
  • Run make lint from the Wagtail root.
• For Python changes: Have you added tests to cover the new/fixed behaviour?
• For front-end changes: Did you test on all of Wagtail’s supported environments?²
  • Please list the exact browser and operating system versions you tested:
  • Please list which assistive technologies ³ you tested:
• For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

1. Development Testing ↩

2. Browser and device support ↩

3. Accessibility Target ↩

[squash-labs]

Manage this branch in Squash

Test this branch here: https://jaivignesh-afkfixadded-false-i-f51v3.squash.io

[gasman]

Hi @Jaivignesh-afk - thanks for the PR.
It looks like this also contains your changes from #11636 - please make sure you start your PRs from a fresh version of the main branch. Also, please can you add a test for this?

[Jaivignesh-afk]

I acknowledge my oversight, I will try to follow that next time. I will be adding the tests asap

[Jaivignesh-afk]

Could you please clarify where I should write these tests, like in test_page_model.py or test_edit_handlers.py or some other file? Additionally, what aspects should I focus on when writing tests? For example, should I ensure that model validation is skipped?

[gasman]

The best way to approach tests is to ask: "what does this change allow an end-user to do, that they couldn't do before?" In this case, they will be able to use the 'Unlock' view in the admin to unlock a page with validation errors. So, we want a test that does the following:

• creates a locked page containing a validation error
• calls the "unlock" view
• verifies that it completes with no errors, and results in the page being unlocked

Tests for the lock/unlock views can be found in wagtail/admin/tests/pages/test_page_locking.py. The test you add will be mostly the same as test_unlock_post, just with some changes to how self.child_page is set up at the start, to introduce a validation error.

[Jaivignesh-afk]

Ok, Thank you for the tips!!