Experimental Feature: New ImageBlock for StreamField (Work in Progress) #11791
+141
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://chiemezuofeatureexperimental-i-v7p7b.squash.io |
gasman
changed the title
Chiemezuo
force-pushed
the
feature/experimental-image-block
branch
from
4e3ebe6
to
b6d78de
Compare
Stormheg
reviewed
May 22, 2024
|
Thank you, @Stormheg :) |
Stormheg
reviewed
May 23, 2024
Comment on lines
+626
to
+628
| # The retrieved rendition needs to be associated with the current image instance, so that any | ||
| # locally-set properties such as contextual_alt_text are respected | ||
| rendition.image = self |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature I'm demoing for my GSoC proposal.
It is a new StreamField block called
ImageBlock.It's a work in progress, but I'd like it to form a basis for my potential conversations about the 'alt text project' with mentors @Stormheg @SaptakS and @thibaudcolas
This is a sample of what the
ImageBlockwould look like:And this is what a sample of what it would look like from the console output:
