Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bindings optional field syntax #3476

Merged
merged 1 commit into from
May 13, 2024

Conversation

atterpac
Copy link
Contributor

@atterpac atterpac commented May 13, 2024

Description

Fixes a bug where an optional json field would get an extra ? appended for example from the issue

type User struct {
     ID string `json:"@ID,omitempty"`
 }

would produce and typescript field of "@ID?"? instead of "@ID"?
Fixes # (issue)
#3464

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [ X ] Linux

Test Configuration

# Wails
Version         | v2.8.2
Revision        | 0f66a98449e4183247ebadf44d9b3aa5fafd738a
Modified        | true
Package Manager | apt

# System
┌─────────────────────────────────────────────────────────────────────────────────────────┐
| OS           | Ubuntu                                                                   |
| Version      | 24.04                                                                    |
| ID           | ubuntu                                                                   |
| Go Version   | go1.22.2                                                                 |
| Platform     | linux                                                                    |
| Architecture | amd64                                                                    |
| CPU          | 12th Gen Intel(R) Core(TM) i5-1235U                                      |
| GPU          | Alder Lake-UP3 GT2 [Iris Xe Graphics] (Intel Corporation) - Driver: i915 |
| Memory       | 7GB                                                                      |
└─────────────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌─────────────────────────────────────────────────────────────┐
| Dependency | Package Name    | Status    | Version          |
| *docker    | docker.io       | Available | 24.0.7-0ubuntu4  |
| gcc        | build-essential | Installed | 12.10ubuntu1     |
| libgtk-3   | libgtk-3-dev    | Installed | 3.24.41-4ubuntu1 |
| libwebkit  | Unknown         | Not Found |                  |
| npm        | npm             | Installed | 10.5.1           |
| *nsis      | nsis            | Available | 3.09-4ubuntu1    |
| pkg-config | pkg-config      | Installed | 1.8.1-2build1    |
└────────────────── * - Optional Dependency ──────────────────┘

# Diagnosis
Optional package(s) installation details:
  - docker: sudo apt install docker.io
  - nsis: sudo apt install nsis

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🎉

@leaanthony leaanthony merged commit 035ede4 into wailsapp:master May 13, 2024
8 checks passed
@Gjergj Gjergj mentioned this pull request May 16, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants