chore: add p2p-circuit component to multiaddr that supports it #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Sep 4, 2023
| // if the multiaddr contains `p2p`, it means that it supports `p2p-circuit` | ||
| // this is avoided from the ENR to save space | ||
| // we should add it | ||
| if (ma.toString().includes("/p2p/")) { |
There was a problem hiding this comment.
I think we should handle particular case because to me it seems possible to accidentally get p2p/p2p-circuit or something.
if (hasP2p && isPeerId(left) && isPeerId(right)) {
...
}Correct me here if I am wrong.
fryorcraken
reviewed
Sep 5, 2023
| multiaddrs.push(multiaddr(multiaddrBytes)); | ||
| let ma = multiaddr(multiaddrBytes); | ||
|
|
||
| // if the multiaddr contains `p2p`, it means that it supports `p2p-circuit` |
There was a problem hiding this comment.
Please provide the full explanation as referred in the description of the PR (that p2p-circuit is not encoded due to space constraint in the ENR, in what form are multiaddr encoded and what is the valid final form of the multiaddr).
|
moving to draft until we investigate more on how to handle p2p-circuit relay better with js-waku |
10 tasks
|
posting not to forget: |
|
superseded by #1619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1527 (comment)