Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of PHP memory limit in variables #403

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add support of PHP memory limit in variables #403

merged 1 commit into from
Mar 11, 2024

Conversation

Kdecherf
Copy link
Member

@Kdecherf Kdecherf commented Mar 10, 2024 •
edited

This PR is based on #374 but it uses envsubst instead of sed-ing php.ini file

Supersedes #374

Fixes #124

@Kdecherf Kdecherf mentioned this pull request Mar 10, 2024
Closed
yguedidi
yguedidi approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@yguedidi yguedidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to target 2.6.x branch instead of master if it's planned to be release as a 2.6.x version :)

@Kdecherf
Add support of PHP memory limit in variables
588c21b 
Supersedes #374

Fixes #124

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf changed the base branch from master to 2.6.x March 11, 2024 10:53
@Kdecherf Kdecherf merged commit bffc141 into 2.6.x Mar 11, 2024
4 checks passed
@Kdecherf Kdecherf deleted the impr/memlimit branch March 11, 2024 10:54
@fho
Copy link

fho commented Apr 1, 2024

@Kdecherf I'm wondering that this change is not in master.
I assume master is the latest in-development version.
Should this be cherry-picked to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguedidi yguedidi yguedidi approved these changes

@j0k3r j0k3r Awaiting requested review from j0k3r

@nicosomb nicosomb Awaiting requested review from nicosomb

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP Memory Limit
3 participants
@Kdecherf @fho @yguedidi