feat: add extension example #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olistic
force-pushed
the
oli/example-extension
branch
2 times, most recently
from
262ea1c
to
751be07
Compare
olistic
force-pushed
the
oli/example-extension
branch
from
64540ef
to
3bbebbe
Compare
olistic
commented
Sep 9, 2022
Comment on lines
+1
to
+24
| { | ||
| "private": true, | ||
| "name": "@wallet-standard/parcel-packager-webextension", | ||
| "version": "0.1.0", | ||
| "author": "Exodus Maintainers <maintainers@exodus.io>", | ||
| "repository": "https://github.com/wallet-standard/wallet-standard", | ||
| "license": "MIT", | ||
| "source": "src/WebExtensionPackager.js", | ||
| "main": "lib/WebExtensionPackager.js", | ||
| "engines": { | ||
| "node": ">=12.0.0", | ||
| "parcel": "^2.7.0" | ||
| }, | ||
| "scripts": { | ||
| "clean": "shx mkdir -p .parcel-cache dist lib && shx rm -rf .parcel-cache dist lib", | ||
| "build": "parcel build" | ||
| }, | ||
| "dependencies": { | ||
| "@parcel/plugin": "2.7.0", | ||
| "@parcel/utils": "2.7.0", | ||
| "nullthrows": "^1.1.1", | ||
| "parcel": "^2.3.2" | ||
| } | ||
| } |
There was a problem hiding this comment.
This will live here temporarily until parcel-bundler/parcel#8424 is merged or published separately.
jordaaash
approved these changes
Sep 9, 2022
| @@ -28,6 +28,7 @@ | |||
| "publish:alpha": "pnpm -r publish --tag alpha" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/chrome": "^0.0.195", | |||
There was a problem hiding this comment.
This dep should probably be specific to the extension package(s) right?
There was a problem hiding this comment.
I tried that first, but it didn't recognize the chrome global that way. Maybe additional TS config is needed at the extension example package?
There was a problem hiding this comment.
Happy to fix in a follow-up PR.
feat: add dApp example
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a browser extension that uses the standard natively to the examples.
For now, it includes: