performance: Cache hello packet encoding/decoding #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello packets for the most part will never change. JSON and encryption are blocking operations that occur some performance cost to use. We can cache our outgoing hello packet, and clear the cache anytime the payload is expected to be manipulated by .advertise(). Likewise, we can cache received hello messages based on IP+Port+data. The size of these messages are small and should result in negligible memory increase, but at the benefit of a major reduction in CPU cost to avoid repeatedly calling encrypt/encrypt and JSON stringify/parse. In a large ensemble of nodes, this can add significant CPU reduction.
This was referenced Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello packets for the most part will never change. JSON and encryption are blocking operations
that occur some performance cost to use.
We can cache our outgoing hello packet, and clear the cache anytime the payload is expected
to be manipulated by .advertise().
Likewise, we can cache received hello messages based on IP+Port+data.
The size of these messages are small and should result in negligible memory increase, but
at the benefit of a major reduction in CPU cost to avoid repeatedly calling
encrypt/encrypt and JSON stringify/parse.
In a large ensemble of nodes, this can add significant CPU reduction.