Add no-floating-promises (#113)

Add no-floating-promises
wantedly · Jul 4, 2019 · a5427fb · a5427fb
2 parents d850b28 + e4fd4c6
commit a5427fb
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 0 deletions.
diff --git a/packages/eslint-config-wantedly-typescript/__tests__/__snapshots__/index.test.js.snap b/packages/eslint-config-wantedly-typescript/__tests__/__snapshots__/index.test.js.snap
@@ -880,6 +880,9 @@ Object {
     "off",
   ],
   "@typescript-eslint/no-extra-parens": "off",
+  "@typescript-eslint/no-floating-promises": Array [
+    "error",
+  ],
   "@typescript-eslint/no-inferrable-types": "error",
   "@typescript-eslint/no-misused-new": "error",
   "@typescript-eslint/no-namespace": "error",

diff --git a/...ages/eslint-config-wantedly-typescript/__tests__/__snapshots__/without-react.test.js.snap b/...ages/eslint-config-wantedly-typescript/__tests__/__snapshots__/without-react.test.js.snap
@@ -877,6 +877,9 @@ Object {
     "off",
   ],
   "@typescript-eslint/no-extra-parens": "off",
+  "@typescript-eslint/no-floating-promises": Array [
+    "error",
+  ],
   "@typescript-eslint/no-inferrable-types": "error",
   "@typescript-eslint/no-misused-new": "error",
   "@typescript-eslint/no-namespace": "error",

diff --git a/packages/eslint-config-wantedly-typescript/without-react.js b/packages/eslint-config-wantedly-typescript/without-react.js
@@ -127,6 +127,7 @@ module.exports = {
     "@typescript-eslint/indent": "off",
     "@typescript-eslint/no-array-constructor": "error",
     "@typescript-eslint/no-explicit-any": ["off"],
+    "@typescript-eslint/no-floating-promises": ["error"],
     "@typescript-eslint/no-unused-vars": [
       "error",
       { varsIgnorePattern: "^_", argsIgnorePattern: "^_", ignoreRestSiblings: true },

diff --git a/packages/frolint/base.js b/packages/frolint/base.js
@@ -46,6 +46,12 @@ function getCli(cwd, eslintConfigPackage = "eslint-config-wantedly-typescript",
       }
     : {};
   const cacheLocation = path.resolve(cwd, "node_modules", ".frolintcache");
+  const parserOptions =
+    netEslintConfigPackage.indexOf("typescript") > -1
+      ? {
+          project: eslintConfig.project || path.resolve(cwd, "tsconfig.json"),
+        }
+      : undefined;
 
   const cli = new eslint.CLIEngine({
     baseConfig: { extends: [netEslintConfigPackage], settings: { ...reactSettings } },
@@ -54,6 +60,7 @@ function getCli(cwd, eslintConfigPackage = "eslint-config-wantedly-typescript",
     ignorePath: eslintConfig.ignorePath,
     cache: true,
     cacheLocation,
+    parserOptions,
   });
 
   return cli;

diff --git a/tsconfig.json b/tsconfig.json
@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {
+    "target": "es2017",
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "strict": false,
+    "allowJs": true,
+    "noEmit": true
+  },
+  "include": ["packages/**/*"]
+}