Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-peer): Fix typescript version constraint #1130

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

chloe463
Copy link
Contributor

@chloe463 chloe463 commented Dec 26, 2023

Why & What

It works with the latest TypeScript, so it doesn't need to narrow TS version.

@github-actions github-actions bot added repo Root directory of this project eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript labels Dec 26, 2023
@chloe463 chloe463 marked this pull request as ready for review December 26, 2023 06:59
@chloe463
Copy link
Contributor Author

@kalvin807 Could you please review this?

Copy link
Contributor

@kalvin807 kalvin807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chloe463
Copy link
Contributor Author

Thank you 👍

@chloe463 chloe463 merged commit 7ca338c into master Dec 26, 2023
5 checks passed
@chloe463 chloe463 deleted the chloe463/build/fix-peer-dep branch December 26, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants