-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in changes from drpayyne's fork #501
Conversation
Set docker user as root during sync creation, but set default-owner-beta and default-group-beta as 'www-data' to maintain the right permissions.
Merge multi-arch into debian line
xdebug3 doesn't work without this condition
Fix XDEBUG 3 on CLI
Fix home dir for www-data user
Fix home dir for www-data user
Fix incorrect check for ssh agent
No need for recursive chown
[2/2] Reduce php-fpm image size
Thanks for this PR @navarr! I planned to create PRs and provide all support required to get multi-arch support, but I'm not sure what's the way forward for this repo as I've not gotten much from this repo. It's not a simple PR from the fork as Warden does much more than just Magento 2 and there's a lot to be tested and I change the fundamental OS of the images from centOS to debian. There are multiple issues with lots of my thoughts and opinions, but I am still essentially waiting for a green-light to bring multi-arch support to the root Warden repo. |
Indeed, myself and so many more developers whom I just know in the agency I work at, use my fork as a daily driver for all our projects. So it's definitely working and stable! :) |
Many of the images have been addressed in #505. Still a few (php!) pending. Closing since merging the fork in without changes isn't feasible, so going to close this, but I don't plan to simply let this drop |
@davidalger, Is there any update on the status of supporting Mac M1s? drpayyne's fork is the only way my team can use Warden with Magento 2 on my Mac M1 machines. On the current implementation of Warden, Magento 2 runs really slow, Mailhog doesn't work for me at all and Elasticsearch is spotty only working some of the time. However, the fork does not work for WordPress implementations so definitely some work needs to be done there to get it fully functional with more than just Magento. |
I'm unsure why a PR doesn't already exist, but thought I'd open this one.
I've been using this as my daily driver for months now and so far have no concerns.
What needs doing/testing to make this update happen?