ci(github): update CODEOWNERS #1770
Conversation
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
lachieh
force-pushed
the
ci/codeowners-fix
branch
from
b092fc9
to
c71bdc4
Compare
|
So @lachieh the preview of the file in the PR actually still has the errors -- I think it's still a problem? I also see different cases (
|
|
Yeah, that's all that I changed. I'm thinking this is an issue with the repo permissions rather than the file itself. @thomastaylor312, can you take a look to see that all these groups have write permission on this repo?
|
|
@lachieh none of those have access. Do they all need write level access or something else? |
|
@thomastaylor312 Assuming they need write access but it might be solved with something lower. Probably makes sense to have write since those groups are responsible for at least part of the repo. The error that shows up when you view the CODEOWNERS file says there are issues: |
There was a problem hiding this comment.
@lachieh Should be good to go now. I added those teams with the proper access
|
Ok that solved it. Didn't really need to merge since apparently repos and groups are case-insensitive but merged anyway for naming consistency. |
Feature or Problem
@vados-cosmonic noticed this issue when viewing the
.github/CODEOWNERSfile which I think is caused by a capitalization in the team name. It might not, though, so 🤷♂️.