fix: Make wash push returned digest based on the pushed manifest #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
approved these changes
May 10, 2024
joonas
force-pushed
the
fix/wash-push-digest
branch
2 times, most recently
from
ff9a0b3
to
1f92b6a
Compare
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
fix/wash-push-digest
branch
from
1f92b6a
to
7a62c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This addresses a couple of problems:
wash pushwas returning the manifest from the manifest-attached config, not the manifest itself.wash pushwas passing in an empty hashmap forannotationseven if there were none, which resulted in an empty"annotations": {}being stored on the registry, when it really should've just been omitted altogetherIn addition, it adds logic to calculate the manifest digest locally based on an alphabetically sorted set of bytes to match the behavior of the most commonly available/widely deployed registry, distribution.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification