Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): added a missing word #328

Merged
merged 3 commits into from Mar 18, 2024
Merged

Conversation

siddharthkhonde
Copy link
Contributor

Feature or Problem

Typo fix in "https://wasmcloud.com/docs/tour/why-wasmcloud"

Manual Verification

deployed the site locally and manually tested the change

@siddharthkhonde siddharthkhonde requested a review from a team as a code owner March 17, 2024 21:06
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for dreamy-golick-5f201e ready!

Name Link
🔨 Latest commit 442a425
🔍 Latest deploy log https://app.netlify.com/sites/dreamy-golick-5f201e/deploys/65f87bea9b5aab00087b817a
😎 Deploy Preview https://deploy-preview-328--dreamy-golick-5f201e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @siddharthkhonde ! I actually think this part is correct, albeit a possibly run-on sentence. The idea is that the biggest benefits of wasmCloud come after you've built your app, which matches what the last sentence there says. Perhaps it could be a little cleaner, what about:

- Beyond providing an easy-to-use platform that's quick to get started with, we also want to make sure that you understand that the biggest benefits of wasmCloud come after you've built your application.
+ wasmCloud is an easy-to-use platform that's quick to get started with, which is essential for a good developer experience, and this project extends far beyond "Hello World." This page emphasizes the intention behind the design of wasmCloud, and the benefits that follow after you've built your application.

Thank you so much for taking a look at this piece of language and calling it out as something that can be more clear!

@siddharthkhonde
Copy link
Contributor Author

wasmCloud is an easy-to-use platform that's quick to get started with, which is essential for a good developer experience, and this project extends far beyond "Hello World." This page emphasizes the intention behind the design of wasmCloud, and the benefits that follow after you've built your application.

this actually looks much better and well-articulated. let me update the PR :)

Copy link
Contributor

@lachieh lachieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks like you just need to sign your commit and force push and then it can merge. Instructions are on the test.

Signed-off-by: Siddharth Khonde <sidconstructs@gmail.com>
Signed-off-by: Siddharth Khonde <sidconstructs@gmail.com>
@siddharthkhonde
Copy link
Contributor Author

Thank you! Looks like you just need to sign your commit and force push and then it can merge. Instructions are on the test.

Hi @lachieh , thank you so much for the approval. I have amended the commits. kindly advise if it looks good now :)

@lachieh lachieh enabled auto-merge (rebase) March 18, 2024 17:38
@lachieh lachieh merged commit 42a5d3e into wasmCloud:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants