New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typo): added a missing word #328
Conversation
✅ Deploy Preview for dreamy-golick-5f201e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @siddharthkhonde ! I actually think this part is correct, albeit a possibly run-on sentence. The idea is that the biggest benefits of wasmCloud come after you've built your app, which matches what the last sentence there says. Perhaps it could be a little cleaner, what about:
- Beyond providing an easy-to-use platform that's quick to get started with, we also want to make sure that you understand that the biggest benefits of wasmCloud come after you've built your application.
+ wasmCloud is an easy-to-use platform that's quick to get started with, which is essential for a good developer experience, and this project extends far beyond "Hello World." This page emphasizes the intention behind the design of wasmCloud, and the benefits that follow after you've built your application.
Thank you so much for taking a look at this piece of language and calling it out as something that can be more clear!
this actually looks much better and well-articulated. let me update the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks like you just need to sign your commit and force push and then it can merge. Instructions are on the test.
Signed-off-by: Siddharth Khonde <sidconstructs@gmail.com>
Signed-off-by: Siddharth Khonde <sidconstructs@gmail.com>
6782a5c
to
4f04705
Compare
Hi @lachieh , thank you so much for the approval. I have amended the commits. kindly advise if it looks good now :) |
Feature or Problem
Typo fix in "https://wasmcloud.com/docs/tour/why-wasmcloud"
Manual Verification
deployed the site locally and manually tested the change