Remove Send bound from FunctionEnv
#4634
Open
+31
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
non-send-environments
branch
3 times, most recently
from
66b136e
to
2e48e6b
Compare
|
Hi @syrusakbary, the system automatically assigned you to review this — but if somebody else should do it please let me know whom to request 😃 |
Twey
force-pushed
the
non-send-environments
branch
from
2e48e6b
to
7cb4178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requiring that function environments be
Sendis quite onerous on the Web, in which many objects (including the WasmerInstanceitself, should we wish to pass around a reference to it) are notSend. The function environment is not passed between threads in Wasmer, and in typed usage the user never sees the trait object, only concrete instances of it after casting — which means that all user-visible types will remainSendif the user should wish to pass them around.