Use raw_arg for CMD on Windows #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMD uses special handling for arguments to passed to /C. Unfortunately, this causes errors with quoted program names in these arguments. This commit implements a workaround: When CMD is requested, we build a std::process::Command and pass the argument to /C using the special std::os::windows::process::CommandExt::raw_arg method. The StdCommand is then converted to a TokioCommand and returned. Once tokio-rs/tokio#5810 is fixed, this workaround can be removed. Fixes watchexec#613
|
Would this also be the case for other windows shells e.g. powershell? |
passcod
approved these changes
Jun 24, 2023
|
The documentation for I've also done some testing with PowerShell on Windows. In my tests, unmodified watchexec correctly called the command I specified despite the quoted name (NB: PowerShell treats quoted arguments as strings, so you have to use special syntax |
|
Are the two test failures expected, or did I break something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMD uses special handling for arguments to passed to
/C. Unfortunately, this causes errors with quoted program names in these arguments.This commit implements a workaround: When CMD is requested, we build a
std::process::Commandand pass the the argument to/Cusing the specialstd::os::windows::process::CommandExt::raw_argmethod. TheStdCommandis then converted to aTokioCommandand returned.Once tokio-rs/tokio#5810 is fixed, this workaround can be removed.
Fixes #613