Never manually emit errors on streams

See: nodejs/node#36053

src/es_archiver/actions/load.js

@@ -42,7 +42,7 @@ import {
 const pipeline = (...streams) => streams
   .reduce((source, dest) => (
     source
-      .once('error', (error) => dest.emit('error', error))
+      .once('error', (error) => dest.destroy(error))
       .pipe(dest)
   ));
 

src/optimize/public_path_placeholder.js

@@ -35,7 +35,7 @@ export function replacePlaceholder(read, replacement) {
     takeUntil(Rx.fromEvent(read, 'end'))
   )
     .forEach(error => {
-      replace.emit('error', error);
+      replace.destroy(error);
       replace.end();
     });
 

src/utils/streams/concat_stream_providers.js

@@ -51,7 +51,7 @@ export function concatStreamProviders(sourceProviders, options = {}) {
 
     source
       // proxy errors from the source to the destination
-      .once('error', (error) => destination.emit('error', error))
+      .once('error', (error) => destination.destroy(error))
       // pipe the source to the destination but only proxy the
       // end event if this is the last source
       .pipe(destination, { end: isLast });

src/utils/streams/concat_stream_providers.test.js

@@ -44,7 +44,7 @@ describe('concatStreamProviders() helper', () => {
       () =>
         new Readable({
           read() {
-            this.emit('error', new Error('foo'));
+            this.destroy(new Error('foo'));
           },
         }),
     ]);

x-pack/plugins/reporting/server/browsers/download/download.test.js

@@ -22,7 +22,7 @@ jest.mock('request', () => {
     return new Readable({
       read() {
         if (resp instanceof Error) {
-          this.emit('error', resp);
+          this.destroy(resp);
           return;
         }