Never manually emit errors on streams

See: nodejs/node#36053
watson · Nov 9, 2020 · 34737a9 · 34737a9
1 parent f8bcaa7
commit 34737a9
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/packages/kbn-es-archiver/src/actions/load.ts b/packages/kbn-es-archiver/src/actions/load.ts
@@ -43,7 +43,7 @@ import {
 // are not listened for
 const pipeline = (...streams: Readable[]) =>
   streams.reduce((source, dest) =>
-    source.once('error', (error) => dest.emit('error', error)).pipe(dest as any)
+    source.once('error', (error) => dest.destroy(error)).pipe(dest as any)
   );
 
 export async function loadAction({

diff --git a/packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.test.js b/packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.test.js
@@ -44,7 +44,7 @@ describe('concatStreamProviders() helper', () => {
       () =>
         new Readable({
           read() {
-            this.emit('error', new Error('foo'));
+            this.destroy(new Error('foo'));
           },
         }),
     ]);

diff --git a/packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.ts b/packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.ts
@@ -50,7 +50,7 @@ export function concatStreamProviders(
 
     source
       // proxy errors from the source to the destination
-      .once('error', (error) => destination.emit('error', error))
+      .once('error', (error) => destination.destroy(error))
       // pipe the source to the destination but only proxy the
       // end event if this is the last source
       .pipe(destination, { end: isLast });

diff --git a/src/core/server/utils/streams/concat_stream_providers.test.ts b/src/core/server/utils/streams/concat_stream_providers.test.ts
@@ -44,7 +44,7 @@ describe('concatStreamProviders() helper', () => {
       () =>
         new Readable({
           read() {
-            this.emit('error', new Error('foo'));
+            this.destroy(new Error('foo'));
           },
         }),
     ]);

diff --git a/src/core/server/utils/streams/concat_stream_providers.ts b/src/core/server/utils/streams/concat_stream_providers.ts
@@ -54,7 +54,7 @@ export function concatStreamProviders(
 
     source
       // proxy errors from the source to the destination
-      .once('error', (error) => destination.emit('error', error))
+      .once('error', (error) => destination.destroy(error))
       // pipe the source to the destination but only proxy the
       // end event if this is the last source
       .pipe(destination, { end: isLast });

diff --git a/x-pack/plugins/spaces/server/lib/copy_to_spaces/copy_to_spaces.test.ts b/x-pack/plugins/spaces/server/lib/copy_to_spaces/copy_to_spaces.test.ts
@@ -283,7 +283,7 @@ describe('copySavedObjectsToSpaces', () => {
           new Readable({
             objectMode: true,
             read() {
-              this.emit('error', new Error('Something went wrong while reading this stream'));
+              this.destroy(new Error('Something went wrong while reading this stream'));
             },
           })
         );

diff --git a/x-pack/plugins/spaces/server/lib/copy_to_spaces/resolve_copy_conflicts.test.ts b/x-pack/plugins/spaces/server/lib/copy_to_spaces/resolve_copy_conflicts.test.ts
@@ -290,7 +290,7 @@ describe('resolveCopySavedObjectsToSpacesConflicts', () => {
           new Readable({
             objectMode: true,
             read() {
-              this.emit('error', new Error('Something went wrong while reading this stream'));
+              this.destroy(new Error('Something went wrong while reading this stream'));
             },
           })
         );