Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children Tracking Issue: Required and Non-Required Keys are mixed up #170

Open
jabdoa2 opened this issue May 13, 2024 · 0 comments · May be fixed by #173
Open

Children Tracking Issue: Required and Non-Required Keys are mixed up #170

jabdoa2 opened this issue May 13, 2024 · 0 comments · May be fixed by #173

Comments

@jabdoa2
Copy link
Contributor

jabdoa2 commented May 13, 2024

This bug has existed for a long time in wave. It does not currently expose any externally visible bugs.

Wave tracks its children (configmaps and secrets) in a map. Each child can either be required or not required. However, if you use multiple key references (i.e. in projections, env vars or others) this currently gets mixed up. As soon as one key is required the complete map is marked as required (in parseSecretKeyRef).

The incorrect behavior is even asserted in unit tests. We need to fix it to resolve #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant