Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children Tracking Issue: Wave does not verify if all keys exist in required children #172

Open
jabdoa2 opened this issue May 13, 2024 · 0 comments · May be fixed by #173
Open

Children Tracking Issue: Wave does not verify if all keys exist in required children #172

jabdoa2 opened this issue May 13, 2024 · 0 comments · May be fixed by #173

Comments

@jabdoa2
Copy link
Contributor

jabdoa2 commented May 13, 2024

This bug has existed for a long time in wave. In some cases wave might add a hash annotation even though a child is still missing a key. If used with the new webhooks wave might enable scheduling for pods early (this is how we found #170, #171 and this issue).

Wave tracks its children (configmaps and secrets) in a map. Each child can either be required or not required. Each child can include all keys or only specific keys. If specific keys are referenced and the child is required wave should only start hashing once all keys exist. At the same time scheduling should only be (re-)enabled once all keys exist (same logic internally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant