Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM: Fix CVE Issues #55

Merged
merged 3 commits into from Oct 4, 2022
Merged

ADM: Fix CVE Issues #55

merged 3 commits into from Oct 4, 2022

Conversation

yogeshprasad
Copy link
Contributor

@yogeshprasad yogeshprasad commented Sep 8, 2022

Upgrade Spring Boot and Gson versions.

Copy link
Contributor

@dkuldeep22 dkuldeep22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@locke-chappel locke-chappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of Spring Boot is 2.7.3. Remaining on 2.6.4, while it fixes a number of vulnerabilities, does not resolve all detected issues.

Similarly the current version of gson is 2.9.1. While 2.8.9 does not yet have any detected vulnerabilities is there some technical reason why we can't upgrade to the current version? (2.8.9 is nearly a year old already.)

Copy link
Contributor

@gangadharaswamy gangadharaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yogeshprasad yogeshprasad changed the title Fix CVE Issues ADM: Fix CVE Issues Sep 26, 2022
@yogeshprasad
Copy link
Contributor Author

@locke-chappel Will you please approve if this looks fine?

adm/pom.xml Show resolved Hide resolved
adm/pom.xml Show resolved Hide resolved
adm/pom.xml Show resolved Hide resolved
@yogeshprasad
Copy link
Contributor Author

@locke-chappel Please have a look and approve if things look fine.

Copy link

@locke-chappel locke-chappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming using snakeyaml 1.33 (e.g. > 1.30) with Spring Boot < 2.7.4 works at runtime this should be good. Note that according to the Spring team this may cause runtime a exception in some cases which is why they made a change in 2.7.4 to support snakeyaml 1.31+.

From a security scan point we are good.

@yogeshprasad yogeshprasad merged commit 8555b3c into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants