-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recalculate agent-group hash when executing Agent-group send/recv full #23447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but the endpoint PUT /agents/{agent_id}/upgrade_custom
failed in the checks.
Although it doesn't seem related to the changes introduced, I think we should double check this (launching the test locally to see if it was sporadic may be it). Since 4.7.4
didn't have failures (nor any sporadic issues in this test) and the 4.7.5
release will contain changes to the agent group hash recalculation only.
1fa1e79
to
4b994e0
Compare
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d8a1af5
to
7c8ebc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only two requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
The failing framework unit test check is related to Jenkins. The same happened in v4.7.4. |
Description
Adds the
global recalculate-agent-group-hashes
command to recalculate the agent-groups hash both in the master and workers when theAgent-group send full
is triggered.Logs example
Description of the manual tests executed in #23432 (comment).
Unit Tests