Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability scanner QA tests: Adding more details in case of failure #23457

Merged
merged 1 commit into from
May 20, 2024

Conversation

pereyra-m
Copy link
Member

Related issue
Closes #23226

Description

This PR adds more details to the vulnerability scanner integration test logs. If the tests fail, it will be easier to determine the cause.

Logs/Alerts example

In case of failure, we can see all the missing lines at the end of the log

2024-05-15_21-48

Tests

  • Review logs syntax and correct language
  • QA templates contemplate the added capabilities

sebasfalcone
sebasfalcone previously approved these changes May 16, 2024
Copy link
Member

@sebasfalcone sebasfalcone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebasfalcone sebasfalcone changed the base branch from master to 4.8.0 May 17, 2024 13:29
@sebasfalcone sebasfalcone dismissed their stale review May 17, 2024 13:29

The base branch was changed.

@sebasfalcone sebasfalcone changed the base branch from 4.8.0 to master May 17, 2024 13:30
@sebasfalcone sebasfalcone changed the base branch from master to 4.8.0 May 19, 2024 15:58
@pereyra-m pereyra-m force-pushed the enhancement/23226-improve-QA-tests-logs branch from 23ceaef to a1f8bc8 Compare May 20, 2024 00:20
@sebasfalcone sebasfalcone self-requested a review May 20, 2024 11:59
Copy link
Member

@sebasfalcone sebasfalcone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebasfalcone sebasfalcone marked this pull request as ready for review May 20, 2024 12:00
@Dwordcito Dwordcito merged commit f9bec8a into 4.8.0 May 20, 2024
69 of 70 checks passed
@Dwordcito Dwordcito deleted the enhancement/23226-improve-QA-tests-logs branch May 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance QA tests for Vulnerability Detection to display failures reasons
3 participants