Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP CBF Package #8030

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add PHP CBF Package #8030

merged 1 commit into from
Sep 30, 2020

Conversation

andremacola
Copy link
Contributor

@andremacola andremacola commented Sep 2, 2020

This is a lightweight ST Package to fix your php files with PHP Codebeautifier aka phpcbf. It is based on the original PHP_CodeSniffer package without the phpcs.

The advantage of this plugin is that it acts directly in the Sublime Text buffer, avoiding file reloading thus being faster.

https://github.com/andremacola/sublime-PHP_CBF

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: PHP CBF
Results help

Packages added:
  - PHP CBF

Processing package "PHP CBF"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

Copy link
Contributor Author

@andremacola andremacola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added license to repo

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: PHP CBF
Results help

Packages added:
  - PHP CBF

Processing package "PHP CBF"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: PHP CBF

Packages added:
  - PHP CBF

Processing package "PHP CBF"
  - All checks passed

@FichteFoll
Copy link
Collaborator

The convention is to name these command entries Preferences: PHP CBF Settings.

Since you starte operations from a fork, you aren't allowed to simply attach a license to that and call it your own. We don't want to deal with copyright infringments from our side, especially because they can be very finnicky, but you should be aware of this. Ideally you'd get a license from the original author (by asking for it in an issue or email) and then add your name to it.

@andremacola
Copy link
Contributor Author

The convention is to name these command entries Preferences: PHP CBF Settings.

Since you starte operations from a fork, you aren't allowed to simply attach a license to that and call it your own. We don't want to deal with copyright infringments from our side, especially because they can be very finnicky, but you should be aware of this. Ideally you'd get a license from the original author (by asking for it in an issue or email) and then add your name to it.

This package is only based on, still.... please see squizlabs/sublime-PHP_CodeSniffer#1 I have the authorization.

@FichteFoll
Copy link
Collaborator

This package is only based on

Sure, but that is how copyright functions in most legislations. It was mostly meant as a heads-up anyway in an attempt to spread awareness about license-less repositories, although you are not at fault. The written authorization in the referenced issue is definitely enough for me personally, though, again, I'm not going to precautiously intervene in any such issues until copyright claims are made.

@FichteFoll FichteFoll merged commit 5bd86e5 into wbond:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants