Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elevator #8875

Closed
wants to merge 1 commit into from
Closed

Conversation

kapitanluffy
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Elevator

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Elevator
Results help

Packages added:
  - Elevator

Processing package "Elevator"
  - ERROR: Invalid key '<character>'
    - File: Default.sublime-keymap
    - Binding: {"args": {"forward": false}, "command": "elevator_move", "keys": ["alt+up", "<character>"]}
  - ERROR: Invalid key '<character>'
    - File: Default.sublime-keymap
    - Binding: {"args": {"forward": true}, "command": "elevator_move", "keys": ["alt+down", "<character>"]}

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Elevator

Packages added:
  - Elevator

Processing package "Elevator"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Looks like you're basically providing what LineJumper already does. That's a pretty stale package though. Please find out if you can contribute to that package instead of adding a new package. Maybe you can even take over that repo. Otherwise, if that does not work out, we can consider removing that existing package with yours, and bring the updated and improved functionality to more users.

@braver
Copy link
Collaborator

braver commented Mar 27, 2024

Please let us know if things worked out with LineJumper.

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Mar 27, 2024
@kapitanluffy
Copy link
Contributor Author

Please let us know if things worked out with LineJumper.

Will do. I contacted the author 👍

@braver braver removed the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Mar 28, 2024
@braver
Copy link
Collaborator

braver commented May 14, 2024

Looks like the answer to your question is "no" 😄. Feel free to proceed with a replacement of the existing entry with yours.

@kapitanluffy
Copy link
Contributor Author

Looks like the answer to your question is "no" 😄. Feel free to proceed with a replacement of the existing entry with yours.

Oh, this has been out of my radar. Yeah, tried reaching out but he did not reply. What should I do to proceed?

@braver
Copy link
Collaborator

braver commented May 16, 2024

The cleanest thing to do is remove the existing entry for LineJumper, and add "LineJumper" to the previous_names of your package (example: https://github.com/wbond/package_control_channel/pull/8875/files#diff-2b7dc45bc94d46ab4847d3281d04dac17d5f228e762a8491333857d6ca7cc6d2R455). Also ensure your package has a version higher than the last one for LineJumper (1.0.0). This effectively replaces that with yours and will upgrade existing users to the latest version of your package. Bonus points for adding an upgrade message (docs) telling those users what happened.

@kapitanluffy
Copy link
Contributor Author

Ok. Got it. I will close this for now. I will add the highlighting feature from linejumper and reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants