Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "Redo" package #8887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the "Redo" package #8887

wants to merge 1 commit into from

Conversation

ISSOtm
Copy link
Contributor

@ISSOtm ISSOtm commented Mar 10, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette. (It's a build system.)
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package adds support for the Redo build system, adding a build system and syntax definition.

There are no packages like it in Package Control.

For bonus points, also considered how the review guidelines apply to this package:
https://github.com/wbond/package_control_channel/wiki#reviewing-a-package-addition

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Redo

Packages added:
  - Redo

Processing package "Redo"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Mar 27, 2024

Please use a consistent suffix to your scopes, even in the hidden syntax. e.g. redo_ouput.

I think there might be a better way to create your syntax, by simply extending the default bash syntax. Try this:

%YAML 1.2
# https://www.sublimetext.com/docs/syntax.html
---
name: Redo
scope: source.redo
version: 2
extends: Packages/ShellScript/Bash.sublime-syntax

file_extensions:
  - do

This might mean you'd have to bump your requirement to something more recent though, which should not be a problem anyway. I would suggest going with 4142 as a minimum (that's already more than a year old).

@braver
Copy link
Collaborator

braver commented May 14, 2024

Please respond to the feedback to continue this PR.

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label May 14, 2024
@ISSOtm
Copy link
Contributor Author

ISSOtm commented May 27, 2024

Please use a consistent suffix to your scopes, even in the hidden syntax. e.g. redo_ouput.

I've done it that way for consistency with other syntaxes, like the built-in Makefile, or e.g. Rust Enhanced. Not sure which way should be privileged.

I think there might be a better way to create your syntax, by simply extending the default bash syntax. Try this:

[...]

This might mean you'd have to bump your requirement to something more recent though, which should not be a problem anyway. I would suggest going with 4142 as a minimum (that's already more than a year old).

Okay, fair enough. I can't perform the modification right now, but I will. Documentation indicates that the requirement is 4075, FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided stale The pull request needs to be updated but has not been within the recent past (2 weeks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants