Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Add Folder To Project 2'. #8904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dennykorsukewitz
Copy link
Contributor

@dennykorsukewitz dennykorsukewitz commented Apr 4, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

Hi guys,
my package is Sublime-AddFolderToProject

AddFolderToProject is a Sublime Text package that streamlines the process of adding and removing folders to and from your projects. It provides a set of commands and context menu options to manage your project's folder structure directly from the editor.

This extension already started as a small function in the Znuny-Sublime package.
However, I had to extend this function and place it in an extra package.

My package is similar to AddFolderToProject-SublimePlugin:
I noticed that there is already an AddFolderToProject-SublimePlugin package.

However it should still be added because:
But apparently this is no longer maintained since 09.02.2015. Issues and PullRequest were not further processed.

I have compiled and revised my functions and the functions of my colleague.
I have solved all known problems and now want to make it available.

Of course, I don't want to displace my colleague's work. That's why I've given the package the 2.
Or should we replace the existing one?

I will tag a release if nothing speaks against this merge from your side.

ChannelRepositoryTools: Test Default Channel

Running Default Channel Tests
  ----------------------------------------------------------------------
  Ran 9682 tests in 0.175s
  
  OK

@dennykorsukewitz dennykorsukewitz changed the title Added Add Folder To Project 2. Added 'Add Folder To Project 2'. Apr 4, 2024
@dennykorsukewitz dennykorsukewitz marked this pull request as ready for review April 4, 2024 22:08
@deathaxe
Copy link
Contributor

deathaxe commented Apr 7, 2024

If an unmaintained old package already exists with nearly the same (or less) functionality, a valid option was to replace it (or take over its name).

Another but way simpler package to note is AddRemoveFolder.

With all the functionality of your package however a name like "Folder Manager" was probably a better fit.

Actually I like the idea of having a single or limited amount of high quality packages, which handle all major aspects of managing folders and cooperate well with packages like Project Manager or Project and Workspace Management.

Other recently updated packages with focus to handling folders are

  • a Folder Aliaser to change folders' labels.
  • a AutoProjects to auto-generate sublime-project files for folders opened via subl <folder>.

Note

I was already created a command to remove folders, too, which makes use of ST's InputHandlers for a more seamless and more modern looking integration into Command Palette.

grafik


With out-of-the-box existing Project: Add Folder command, I wonder if it would also make sense to group commands of your package under Project: for usability-consistency reasons, e.g.:

  • Project: Add current file's folder
  • Project: Add current file's parent folder
    note: the default "Project: Add Folder" opens a dialog box to choose any folder
  • Project: Remove Folder
  • ...

A command Copy Path is already available via context menu in side bar. It copies a selected folder's or file's absolute path. So the commands in your package are redundant.

Packages like File Manager also provide more variants of them.


Any new plugin must opt-in to python 3.8 plugin_host via .python-version.

@dennykorsukewitz
Copy link
Contributor Author

Hey @deathaxe ,
thanks for all the feedback.
I've seen some of the other packages, but you've also shown me a few new ones.

If we replace the existing one, I would have to do the following:

  • .python-version.
  • change code to use of ST's InputHandlers
  • group commands under Project: for usability-consistency reasons
  • remove obsolete Copy Path command
  • release

But now I'm honestly confused as to what I should do best. What would be your suggestion?

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants