Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starlark syntax #8916

Merged
merged 1 commit into from
May 22, 2024
Merged

Add Starlark syntax #8916

merged 1 commit into from
May 22, 2024

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented May 9, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is syntax highlighting for Starlark language.

There are no packages like it in Package Control.

@Vasfed
Copy link
Contributor Author

Vasfed commented May 9, 2024

@packagecontrol-bot please review

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Starlark
Results help

Packages added:
  - Starlark

Processing package "Starlark"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: starlark.sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Starlark

Packages added:
  - Starlark

Processing package "Starlark"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Starlark

Packages added:
  - Starlark

Processing package "Starlark"
  - All checks passed

@braver braver merged commit fb2a0e5 into wbond:master May 22, 2024
3 checks passed
@braver
Copy link
Collaborator

braver commented May 22, 2024

Well done 👍🏻

@deathaxe
Copy link
Contributor

What's the main difference between Starlark and the syntax provided by https://github.com/niosus/BazelSyntax?

@braver
Copy link
Collaborator

braver commented May 24, 2024

Oh, nice find… one thing this new one has going for it is that it has the correct name 😁. Starlark is not limited to the Bazel project, it’s a language all on its own. .. Although I guess we did duplicate a bit now, the new one is probably much more findable (the old one doesn’t even mention Starlark).

@deathaxe
Copy link
Contributor

But the older one looks way more complete and ST like, while the new one seems to be just a converted VS Code syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants