Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take over Materialize development #8919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyphlar
Copy link

@zyphlar zyphlar commented May 14, 2024

The existing repo has been archived for 4 years and lacking activity for 7; I've merged an open PR enabling colored title bars and published to Github.

  • I'm the package's new author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.

My package is a theme

My package is a fork of Materialize, however it should still be added because the existing Materialize has been abandoned and marked as archived for a long time.

The existing repo has been archived for 4 years and lacking activity for 7; I've merged an open PR enabling colored title bars and published to Github.
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Materialize

@FichteFoll
Copy link
Collaborator

Regarding your changes, I suggest to re-use the existing themed_title_bar setting for your theme instead of inventing your own (material_theme_title_bar) as it is encouraged to be used for this purpose. Furthermore, I don't really understand your comment about "On OSX" because it will be active on all platforms.

Finally, I'm also pinging @saadq to inform them of this takeover. The old repo is archived, so I don't expect any objections, but even for archived repos it makes sense to respect out 2 week grace period for the previous maintainer to raise concerns.

@FichteFoll FichteFoll added takeover Package maintainership is changing awaiting objection A package is being replaced or moved and awaits objection from a current maintainer labels May 14, 2024
@zyphlar
Copy link
Author

zyphlar commented May 20, 2024

I'll investigate, thanks -- so far this is just a merge of upstreams so I'll have to develop and test improvements.

Also happy to make a new/renamed project like Materialize2024 or something out of respect for @saadq's hard work and rights to the project, obviously keeping the same package name will help existing users with updates etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting objection A package is being replaced or moved and awaits objection from a current maintainer takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants