Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose @types/node as a peer dependency #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose @types/node as a peer dependency #332

wants to merge 1 commit into from

Conversation

nevir
Copy link

@nevir nevir commented Jan 16, 2023

ts-node declares @types/node as a peer dependency, so we've gotta also expose it in order to satisfy the peer dependency requirement

Fixes #319

@nevir
Expose @types/node as a peer dependency
96e7311 
ts-node declares `@types/node` as a peer dependency, so we've gotta also expose it in order to satisfy the peer dependency requirement
@JasonMan34
Copy link

+1

@rvitaliy
Copy link

still waiting for this merge 🙏 , my temporarily fix:

packageExtensions:
  ts-node-dev@*:
    peerDependencies:
      "@types/node": "^18.15.3" #TMP FIX W8 for merge of: https://github.com/wclr/ts-node-dev/pull/332

@TDSCondeNast
Copy link

Is there any reason not to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts-node-dev doesn't provide @types/node (p9e5bc), requested by ts-node
4 participants
@nevir @JasonMan34 @rvitaliy @TDSCondeNast