Fix setting link-time variables for release version #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
approved these changes
Jul 21, 2023
a-hilaly
approved these changes
Jul 21, 2023
Himangini
approved these changes
Jul 21, 2023
The import name passed to `ldflags` was incorrect, causing variables in the `version` package to remain unset. This was causing `eksctl version` to show a `-dev` suffix for both release candidates and full releases. This changelist fixes setting link-time variables for the release version.
cPu1
force-pushed
the
fix-release-version
branch
from
97d7698
to
6c67b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The import name passed to
ldflagswas incorrect, causing variables in theversionpackage to remain unset. This was causingeksctl versionto show a-devsuffix for both release candidates and full releases.This changelist fixes setting link-time variables for the release version.
Fixes #6835
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く