Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coredns 1.28 asset #7126

Merged
merged 1 commit into from Oct 2, 2023
Merged

Fix coredns 1.28 asset #7126

merged 1 commit into from Oct 2, 2023

Conversation

Himangini
Copy link
Collaborator

@Himangini Himangini commented Oct 2, 2023 •
edited

Description

PR #7108 for 1.28 added hardcoded image name in coredns asset, this PR fixes broken coredns utils update command

Closes #7125

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Himangini Himangini mentioned this pull request Oct 2, 2023
Closed
@Himangini Himangini merged commit b500441 into eksctl-io:main Oct 2, 2023
12 of 13 checks passed
@Himangini Himangini deleted the fix-coredns-asset branch October 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] eksctl utils update-coredns image interpolation broken
2 participants
@Himangini @TiberiuGC