feat: add grafana v10 AlertRule support #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, would it be possible to merge this please? We would also appreciate this change, although it hard to make the change ourselves, having it right in the "main" library would not trigger our "OCDs" as much ;-) |
|
Hi @amotl, would it be possible to merge this? It looks like an essential improvement to support V10 dashboards. |
|
Hi Pawel. I am not a member of the grafanalib project, so I can't help you here. Apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Grafana v10 has a slightly different format for alert rules, so the v9 version of the class cannot be used without overriding the to_json_data method. The PR implements the modified rendering that should work for grafana v10 alerts
Why is it a good idea?
Supporting v10 will help keeping the library relevant in the short term while cog matures. Once cog become mature enough, it might be an interesting option, but for now manual code changes are still the best way to go forward
Context
See #627
Questions