Upgrade client-go version to 10.0.0 #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will
Upgrade:
- k8s.io/client-go v10.0.0
- k8s.io/api version to kubernetes-1.13.0
- k8s.io/apimachinery version to kubernetes-1.13.0
- github.com/imdario/mergo to v0.3.5
Add:
- k8s.io/klog v0.1.0
- sigs.k8s.io/yaml v1.1.0
Changes:
- modified: probe/kubernetes/client.go
- modified: probe/kubernetes/controls.go
To ScaleUp and ScaleDown a Deployment, Scale method was used,
which is removed in client-go-10.0.0
Instead of Scale use UpdateScale method of Deployment to
ScaleUp and ScaleDown the Deployment.
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
|
Commands Used:- |
| scale, err := scaler.Get(resource, id) | ||
| func (c *client) modifyScale(namespaceID, id string, f func(*apiextensionsv1beta1.Scale)) error { | ||
| scaler := c.client.ExtensionsV1beta1().Deployments(namespaceID) | ||
| scale, err := scaler.GetScale(id, metav1.GetOptions{}) |
There was a problem hiding this comment.
Just to be clear, is scaler.GetScale a new thing that doesn't require passing resource around and that's why we can get rid of resource?
There was a problem hiding this comment.
Yes, that is correct.
errordeveloper
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will
Upgrade:
Add:
Changes:
This is the first code drop towards
kubectl describechange. (#1143)To ScaleUp and ScaleDown a Deployment, Scale method was used,
which is removed in client-go-10.0.0. PR (kubernetes/kubernetes#70437)
Instead of Scale use UpdateScale method of Deployment to
ScaleUp and ScaleDown the Deployment.
Signed-off-by: Akash Srivastava akashsrivastava4927@gmail.com