various fixes to indexing queue #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennedi
force-pushed
the
async-indexing-logs
branch
from
2a335bf
to
7d615c7
Compare
simplify queue implementation
|
antas-marcin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
This PR fixes a few issues with the indexing queue and adds two env vars:
ASYNC_MAX_CHUNKS_PER_TICK: to control the dequeue speed, i.e how many batches to index at a time (defaults to the number of cores)ASYNC_THROTTLING: to limit the indexing to 1 batch at a time during importing. This increases the import speed drastically.Review checklist