Add modules-provider to remote incoming so remote aggregations functions correctly #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re handled throughout the entire project
… defaults to keep profiling on by default
Accidentally forgot to actually check the env - my bad
Prepare release v1.25.0-rc.0
Merge stable/v1.25 into main
…n on db.Shutdown()
fix: don't return shutdown error incase the shard was already shutdow…
Revert "fix: don't return shutdown error incase the shard was already shutdow…" to re open against stable/v1.25
Sync main with stable/v1.25
Signed-off-by: Loic Reyreaud <loic@weaviate.io>
add retry on failure in CI for tests instability
Added an environment variable for disabling the go profiler setup
Merge stable/v1.25 into main
|
Needs a test, but is ready for comments |
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 5 to 6. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v5...v6) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ngci/golangci-lint-action-6 Bump golangci/golangci-lint-action from 5 to 6
|
|
Replaced by #4926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Aggregate hybrid neartext filters are currently failing because aggregate does not have access to moduleProvider.
This patch adds a field called modules to RemoteIndexIncoming and makes sure it is populated with the correct modules provider, sends this to the aggregations.
This fixes a problem with remote hybrid neartext filters in aggregations. Aggregations without hybrid neartext subsearches were not affected
Review checklist