Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race in tombstone cleanup #4910

Merged
merged 2 commits into from
May 15, 2024
Merged

fix race in tombstone cleanup #4910

merged 2 commits into from
May 15, 2024

Conversation

asdine
Copy link
Member

@asdine asdine commented May 14, 2024

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@asdine asdine requested review from trengrj and abdelr May 14, 2024 08:49
@asdine asdine changed the title fix race in delete logic fix race in tombstone cleanup May 14, 2024
trengrj
trengrj previously approved these changes May 15, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@asdine asdine merged commit 9d8afa5 into stable/v1.25 May 15, 2024
42 checks passed
@asdine asdine deleted the fix-race-and-flaky-test branch May 15, 2024 13:13
@trengrj trengrj mentioned this pull request May 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelr abdelr abdelr approved these changes

@trengrj trengrj trengrj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asdine @trengrj @abdelr