Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop using pnpm action-setup, fix the CI #1137

Merged
merged 1 commit into from May 27, 2022

Conversation

chenjiahan
Copy link
Member

PR Details

Description

@pnpm/action-setup fails on CI, see pnpm/action-setup#44

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

⚠️ No Changeset found

Latest commit: fa086ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1137 (fa086ee) into main (4f97d0c) will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files         827      827           
  Lines       36310    36305    -5     
  Branches     6902     6900    -2     
=======================================
- Hits        22155    22152    -3     
+ Misses      14120    14118    -2     
  Partials       35       35           
Impacted Files Coverage Δ
...set-app/src/built-in/babel-plugin-ssr-loader-id.ts 0.00% <0.00%> (ø)
packages/runtime/src/loader/useLoader.ts 89.55% <ø> (+2.59%) ⬆️
packages/runtime/src/loader/loaderManager.ts 94.78% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60ce04...fa086ee. Read the comment docs.

@chenjiahan chenjiahan enabled auto-merge (squash) May 27, 2022 05:34
@chenjiahan chenjiahan merged commit c3a31de into web-infra-dev:main May 27, 2022
@chenjiahan chenjiahan deleted the pnpm_action_setup_0527 branch May 27, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants