fix(builder-shared): The http://0.0.0.0:port can't visit in windows #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublicPath as //0.0.0.0:${port}/
🦋 Changeset detectedLatest commit: 419f647 The changes in this PR will be included in the next version bump. This PR includes changesets to release 213 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
+ Coverage 57.59% 57.94% +0.34%
==========================================
Files 672 668 -4
Lines 17794 17723 -71
Branches 3876 3852 -24
==========================================
+ Hits 10249 10270 +21
+ Misses 6934 6846 -88
+ Partials 611 607 -4
... and 74 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
chenjiahan
reviewed
Apr 14, 2023
GiveMe-A-Name
changed the title
GiveMe-A-Name
changed the title
GiveMe-A-Name
changed the title
//0.0.0.0:${port}/;
GiveMe-A-Name
changed the title
//0.0.0.0:${port}/;//0.0.0.0:${port}/;
GiveMe-A-Name
changed the title
//0.0.0.0:${port}/;
9aoy
reviewed
Apr 14, 2023
chenjiahan
reviewed
Apr 14, 2023
chenjiahan
previously approved these changes
Apr 17, 2023
chenjiahan
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 4911ea3
This pull request fixes a bug in the asset-prefix feature of the
@modern-js/builder-sharedpackage, which caused problems in Windows systems when using0.0.0.0as the hostname for the publicPath option in the webpack output configuration. It updates thegetPublicPathfunction, theindex.test.tsfile, and the.changesetfile accordingly.Details
🤖 Generated by Copilot at 4911ea3
0.0.0.0as the hostname for the publicPath option in the webpack output configuration, which causes problems in Windows systems (link, link).changesetfile with fix messages in English and Chinese, indicating a patch-level change for the@modern-js/builder-sharedpackage (link)getPublicPathfunction inoutput.tsto check if the hostname is not equal to0.0.0.0, and only set the publicPath to//${hostname}:${port}/if that is the case, otherwise leave it as an empty string (link)@modern-js/builder-sharedpackage to reflect the change in the publicPath option (link, link, link, link)DEFAULT_DEV_HOSTconstant from@modern-js/utils(link)/static/js/part of the publicPath in the HTML file, instead of the//${DEFAULT_DEV_HOST}:3333part (link)//${DEFAULT_DEV_HOST}:3333(link)http://localhost:3333as the URL, instead ofhttp:${expected}(link)Related Issue
Checklist
pnpm run change.