Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pnpm deprecated warnings #3796

Merged
merged 1 commit into from May 30, 2023

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 30, 2023

Summary

Ref: pnpm/pnpm#4306

FIx:

Screen Shot 2023-05-30 at 11 05 20

🤖 Generated by Copilot at 1435144

This pull request adds a new package.json field to allow using deprecated dependencies with npm 7. This helps the modern.js project to migrate smoothly and avoid installation issues.

Details

🤖 Generated by Copilot at 1435144

  • Add allowedDeprecatedVersions field to package.json to specify deprecated dependencies (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

⚠️ No Changeset found

Latest commit: 1435144

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.29 🎉

Comparison is base (99693f0) 57.59% compared to head (1435144) 57.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3796      +/-   ##
==========================================
+ Coverage   57.59%   57.89%   +0.29%     
==========================================
  Files         672      646      -26     
  Lines       17794    17284     -510     
  Branches     3876     3773     -103     
==========================================
- Hits        10249    10006     -243     
+ Misses       6934     6668     -266     
+ Partials      611      610       -1     

see 278 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caohuilin caohuilin merged commit 6837461 into web-infra-dev:main May 30, 2023
8 checks passed
@chenjiahan chenjiahan deleted the deprecated_warnings_0530 branch May 30, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants