Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 docs(storybook): Replace storybook/main.js in storybook/main.ts #5641

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h7ml
Copy link

@h7ml h7ml commented Apr 15, 2024

Replace storybook/main.js in the document with the actual storybook/main.ts generated

Summary

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 5e184d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@h7ml
Copy link
Author

h7ml commented Apr 15, 2024

image

The command npx modern new generates .storybook\main.ts instead of .storybook\main.js in the document

image

@h7ml
Copy link
Author

h7ml commented Apr 15, 2024

Also, I noticed that the documentation Use Storybook states

该命令会创建好 Storybook 常用的模版,包括

  • 创建配置文件夹 .storybook,以及默认配置文件 .storybook/main.ts
  • 创建 stories 组件示例
  • 更新 package.json,新增依赖 @storybook/addon-essential 和 @modern-js/storybook,以及创建 storybook 相关脚本。

Then . storybook/main.js in the document is not a product of npx modern new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant