fix(core): call onAfterBuild on every build
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
xc2
force-pushed
the
fix/onAfterBuild-on-every-build
branch
from
716b750
to
7c77c4c
Compare
chenjiahan
approved these changes
Mar 9, 2024
|
Nice 😄 |
chenjiahan
reviewed
Mar 10, 2024
| await p; | ||
| }; | ||
|
|
||
| try { |
There was a problem hiding this comment.
@xc2 I wonder when will hooks.done.tapPromise throw an error here...
There was a problem hiding this comment.
ok I get it, the hooks.done is a sync hook when using multiCompiler..
There was a problem hiding this comment.
MultiCompiler's done hook is a SyncHook. https://github.com/webpack/webpack/blob/6842c9a2c9b70e760143188ffa5baa19a72799cb/lib/MultiCompiler.js#L63
SyncHook's tapPromise is a function that only throws
There was a problem hiding this comment.
yeah, this means if onAfterBuild is an async function, it may not work as expected when Rsbuild use MultiCompiler (has multiple targets)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
fixes #1765
Checklist