Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-svgr): prefer using svgrOptions.exportType option #1789

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Prefer using svgrOptions.exportType option and deprecate the svgDefaultExport option.

This change is to avoid having two options with the same effect.

Related Links

https://github.com/gregberge/svgr/blob/785cba48cca6c27810fca3eaeb4aae86822772cc/website/pages/docs/webpack.mdx#L165

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6120ffb
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/65eeeabd434e9c00080fd12f
😎 Deploy Preview https://deploy-preview-1789--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit a490a09 into main Mar 12, 2024
11 checks passed
@chenjiahan chenjiahan deleted the deprecate_svg_default_export_0311 branch March 12, 2024 02:40
@chenjiahan chenjiahan mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant