Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not log compile warning when warning is ignored #2171

Merged
merged 2 commits into from Apr 22, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented Apr 22, 2024

Summary

should not log compile warning when warning length is 0 (use ignoreWarning)
fix: #2165

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 379f1ea
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/662649c153992700089fa89c
😎 Deploy Preview https://deploy-preview-2171--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy changed the title chore: should not log compile warning when warning length is 0 chore: should not log compile warning when warning is ignored Apr 22, 2024
@chenjiahan chenjiahan changed the title chore: should not log compile warning when warning is ignored fix: should not log compile warning when warning is ignored Apr 22, 2024
@chenjiahan chenjiahan merged commit 22d76c6 into web-infra-dev:main Apr 22, 2024
13 checks passed
@chenjiahan chenjiahan mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Still have compile warning tip when configured ignoreWarning
2 participants