Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-check-syntax): allow to match assets with query #2187

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ymq001
Copy link
Contributor

@ymq001 ymq001 commented Apr 24, 2024

Summary

当 output.filename 为以下配置时,CheckSyntaxPlugin 匹配不到资源文件,进而导致失效了

   filename: {
      js: '[name].js?v=[contenthash:8]',
      css: '[name].css?v=[contenthash:8]',
      svg: '[name].svg?=[contenthash:8]',
      font: '[name][ext]?v=[contenthash:8]',
      image: '[name][ext]?v=[contenthash:8]',
      media: '[name][ext]?v=[contenthash:8]'
    },

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 108199d
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6628ae9225782200085b133e
😎 Deploy Preview https://deploy-preview-2187--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: CheckSyntaxPlugin 适配 output 输出的 query 形式的文件名 fix(plugin-check-syntax): allow to match assets with query Apr 24, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) April 24, 2024 07:37
@chenjiahan
Copy link
Member

Thanks! ❤️

@chenjiahan chenjiahan merged commit 76c4740 into web-infra-dev:main Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants