chore: remove define plugin in rspack-cli (#6219)

* chore: remove define plugin in rspack-cli

* test: add test

packages/rspack-cli/src/rspack-cli.ts

@@ -186,22 +186,6 @@ export class RspackCLI {
 				}
 			}
 
-			// Tells webpack to set process.env.NODE_ENV to a given string value.
-			// optimization.nodeEnv uses DefinePlugin unless set to false.
-			// optimization.nodeEnv defaults to mode if set, else falls back to 'production'.
-			// See doc: https://webpack.js.org/configuration/optimization/#optimizationnodeenv
-			// See source: https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/WebpackOptionsApply.js#L563
-
-			// When mode is set to 'none', optimization.nodeEnv defaults to false.
-			if (item.mode !== "none") {
-				(item.plugins ||= []).push(
-					new rspackCore.DefinePlugin({
-						// User defined `process.env.NODE_ENV` always has highest priority than default define
-						"process.env.NODE_ENV": JSON.stringify(item.mode)
-					})
-				);
-			}
-
 			if (typeof item.stats === "undefined") {
 				item.stats = { preset: "errors-warnings", timings: true };
 			} else if (typeof item.stats === "boolean") {

packages/rspack-cli/tests/build/issue-6214/entry.js

@@ -0,0 +1,2 @@
+const long_name_should_be_minified = process.env.NODE_ENV;
+console.log(long_name_should_be_minified);

packages/rspack-cli/tests/build/issue-6214/index.test.ts

@@ -0,0 +1,9 @@
+import { readFile, run } from "../../utils/test-utils";
+import { resolve } from "path";
+
+it("should not have `process.env.NODE_ENV` when optimization.nodeEnv has been set", async () => {
+	await run(__dirname, ["--mode", "production"]);
+	const mainJs = await readFile(resolve(__dirname, "dist/main.js"), "utf-8");
+	expect(mainJs).toContain("process.env.NODE_ENV");
+	expect(mainJs).not.toContain("long_name_should_be_minified");
+});

packages/rspack-cli/tests/build/issue-6214/rspack.config.js

@@ -0,0 +1,14 @@
+const path = require("path");
+
+/** @type {import('@rspack/cli').Configuration} */
+module.exports = {
+	mode: "development", // will be override to "production" by "--mode"
+	entry: "./entry.js",
+	output: {
+		clean: true,
+		path: path.resolve(__dirname, "dist")
+	},
+	optimization: {
+		nodeEnv: false
+	}
+};