Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump version #2500

Merged
merged 14 commits into from Mar 30, 2023
Merged

fix: bump version #2500

merged 14 commits into from Mar 30, 2023

Conversation

IWANABETHATGUY
Copy link
Collaborator

@IWANABETHATGUY IWANABETHATGUY commented Mar 28, 2023 •
edited

Summary

  1. Main change is pass es_version from options.target into swc_compat, this make compat_by_es_version visitor nomore noop.

Related issue (if exists)

  1. fixed fix problems of upgrade swc #2497
  2. fixed [Bug Report]: swc css parse warning for legacy_ie #2495

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023 •
edited

⚠️ No Changeset found

Latest commit: 617d2e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/bump-version branch 3 times, most recently from 8d1b49e to f188dff Compare March 29, 2023 07:40
@hyf0 hyf0 added the team The issue/pr is created by the member of Rspack. label Mar 29, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/bump-version branch 2 times, most recently from 0c920a1 to a9530ea Compare March 29, 2023 11:44
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 30, 2023 03:21
@IWANABETHATGUY IWANABETHATGUY merged commit a5d3200 into main Mar 30, 2023
6 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/bump-version branch March 30, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

@underfin underfin Awaiting requested review from underfin

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix problems of upgrade swc [Bug Report]: swc css parse warning for legacy_ie
4 participants
@IWANABETHATGUY @jerrykingxyz @ahabhgk @hyf0