Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/modules): bump swc version to fix #3875 and add test #4144

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(css/modules): bump swc version to fix #3875 and add test #4144

merged 2 commits into from
Sep 8, 2023
+785 −105

Conversation

Thiry1
Copy link
Contributor

@Thiry1 Thiry1 commented Sep 7, 2023 •
edited

Summary

bump swc version to fix #3875 and add test.
closes #3875

see also:
swc-project/swc#7917

Test Plan

unit test

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@Thiry1 Thiry1 requested review from a team September 7, 2023 03:51
@Thiry1 Thiry1 requested a review from Boshen as a code owner September 7, 2023 03:51
@Thiry1
Copy link
Contributor Author

Thiry1 commented Sep 7, 2023

If possible, could you release a canary version for me?

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Sep 7, 2023

!canary

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

0.3.2-canary-b047aa7-20230907052555

@Thiry1
Copy link
Contributor Author

Thiry1 commented Sep 7, 2023 •
edited

Thank you for publish!
I've confirmed that #3875 is fixed in our code base.

@Thiry1 Thiry1 requested a review from ahabhgk as a code owner September 8, 2023 05:17
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Sep 8, 2023

Thank you for the contribution!

@h-a-n-a h-a-n-a added this pull request to the merge queue Sep 8, 2023
Merged via the queue into web-infra-dev:main with commit ee3ded1 Sep 8, 2023
14 checks passed
@h-a-n-a h-a-n-a mentioned this pull request Sep 8, 2023
Closed
@Thiry1 Thiry1 deleted the fix/3875 branch September 8, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@Boshen Boshen Awaiting requested review from Boshen

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css modules] class is disappear when compose is chained
2 participants
@Thiry1 @h-a-n-a