Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: refactor: Refactor recalculate UI switch #666

Closed
wants to merge 2 commits into from
Closed

WIP: refactor: Refactor recalculate UI switch #666

wants to merge 2 commits into from

Conversation

sumy7
Copy link
Contributor

@sumy7 sumy7 commented Feb 26, 2024

Summary

This pr consider recalculate UI Switch logic with url query params.

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@sumy7 sumy7 marked this pull request as draft February 26, 2024 09:28
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit ff0a392
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65dc59cc49831b0008406e27
😎 Deploy Preview https://deploy-preview-666--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79
Accessibility: 97
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sumy7
Copy link
Contributor Author

sumy7 commented Feb 26, 2024

@sanyuan0704 any suggestions for this pr? how about plugin components that need to show/hide layout sections.

@sanyuan0704 sanyuan0704 marked this pull request as ready for review February 26, 2024 09:58
@sanyuan0704
Copy link
Collaborator

sanyuan0704 commented Feb 28, 2024 •
edited

globalComponents are not placed in theme package so that it could be handled seperatedly.

@sumy7 sumy7 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sumy7 @sanyuan0704